SOLR-16672: Remove use of setDefaultCollection in SolrCLI #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This turns out to not be an unused config, but instead appears to be used inside of healthcheck, but sort of deeply nested. By moving to an explicit collection parameter, it removes a bit of magic configuration, and does let us remove this at the top... since it's only used in healthcheck. |
epugh
changed the title
dsmiley
approved these changes
Feb 22, 2023
epugh
added a commit
that referenced
this pull request
Feb 23, 2023
Simplify how the Healthcheck command gets it target collection and eradicate an unneeded setDefaultCollection method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16672
found unused (I believe!) parameter...