SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
risdenk
approved these changes
Mar 2, 2023
|
I haven't tried these changes, but its sad that the worker thread is just unmanaged and can't be shutdown. |
dsmiley
approved these changes
Mar 2, 2023
Yes, they should allow passing in an executor or otherwise control it. But Hopefully the timeouts set in the test will now cause the worker to shutdown within 10s. |
janhoy
added a commit
that referenced
this pull request
Mar 2, 2023
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com> (cherry picked from commit f9b800f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16683
The
@ThreadLeakLingeringshould be in millis, not seconds, so 10 means 10ms, but we should wait for 10s.