Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update io.prometheus:* to v0.16.0 #1419

Merged
merged 5 commits into from
Mar 2, 2023
Merged

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Mar 1, 2023

This PR contains the following updates:

Package Type Update Change
io.prometheus:simpleclient_httpserver dependencies minor 0.2.0 -> 0.16.0
io.prometheus:simpleclient_common dependencies minor 0.2.0 -> 0.16.0
io.prometheus:simpleclient dependencies minor 0.2.0 -> 0.16.0

Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@janhoy
Copy link
Contributor

janhoy commented Mar 1, 2023

This is used by prometheus-exporter. The two new jars are for providing trace exemplars for metrics. However, since prom-exporter runs in a separate JVM process from Solr, this won't work, so we exclude it instead. See https://github.com/prometheus/client_java/blob/main/OTEL_EXEMPLARS.md

solrbot and others added 3 commits March 2, 2023 00:25
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
@janhoy janhoy requested a review from risdenk March 1, 2023 23:29
@janhoy
Copy link
Contributor

janhoy commented Mar 1, 2023

It's a bit confusing too that prometheus-exporter, which is a separate java app shares gradle build, and thus versions.props file with main Solr. Ideally the exporter should have its separate build?

@solrbot
Copy link
Collaborator Author

solrbot commented Mar 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
@janhoy janhoy merged commit 8111586 into apache:main Mar 2, 2023
janhoy pushed a commit that referenced this pull request Mar 2, 2023
Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
(cherry picked from commit 8111586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants