SOLR-16240: Fix kerberosPlugin module classloading #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhoy
approved these changes
Apr 5, 2023
|
Yeah will get that stuff cleaned up. Not sure we will want to remove this workaround, it does let us use non-request centric plugins without worrying if those plugins use the thread classloader or not. (This is similar workaround we do for the sql module, which has libraries that will never accept a cloassloader probably...) I don't want to move merge this without an integration test, but I'm not sure how to get that working for kerberos... Might play around with that later if no one else has ideas. |
|
@janhoy added an integration test, which seems to work as expected, and fails when I remove the line that fixes this PR. Let me know if it looks good to you. |
|
LGTM |
risdenk
approved these changes
Apr 10, 2023
HoustonPutman
added a commit
that referenced
this pull request
Apr 10, 2023
Also added an integration test for the hadoop-auth module. (cherry picked from commit d9eba43)
HoustonPutman
added a commit
that referenced
this pull request
Apr 10, 2023
Also added an integration test for the hadoop-auth module. (cherry picked from commit d9eba43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16240
The easy way out vs waiting on a hadoop fix and a hadoop release.