SOLR-16759: Introducing logAll parameter in the feature logger #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruggero
commented
Apr 24, 2023
solr/modules/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java
Outdated
Show resolved
Hide resolved
solr/modules/ltr/src/java/org/apache/solr/ltr/CSVFeatureLogger.java
Outdated
Show resolved
Hide resolved
solr/modules/ltr/src/java/org/apache/solr/ltr/FeatureLogger.java
Outdated
Show resolved
Hide resolved
solr/modules/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java
Outdated
Show resolved
Hide resolved
solr/modules/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java
Outdated
Show resolved
Hide resolved
solr/modules/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java
Outdated
Show resolved
Hide resolved
.../ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
Outdated
Show resolved
Hide resolved
.../ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
Outdated
Show resolved
Hide resolved
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
7 times, most recently
from
afe2f38
to
bcc54a8
Compare
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
from
f38129d
to
2d6252f
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
.../ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
Show resolved
Hide resolved
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
2 times, most recently
from
f54a4b5
to
07f6a65
Compare
alessandrobenedetti
approved these changes
Apr 28, 2023
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
3 times, most recently
from
d23805f
to
bb4c368
Compare
|
Running checks, merging on monday! |
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
from
35b5349
to
2ad0548
Compare
aruggero
commented
May 12, 2023
.../ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
Outdated
Show resolved
Hide resolved
aruggero
commented
May 12, 2023
.../ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
Outdated
Show resolved
Hide resolved
alessandrobenedetti
force-pushed
the
feature/feature-logger-extract-all
branch
from
bed14b6
to
543c71d
Compare
alessandrobenedetti
approved these changes
May 15, 2023
alessandrobenedetti
pushed a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16759
Description
Currently, there is no possibility of deciding how many features to log.
It would be useful to give the user the ability to decide if to print all the features of the store or only the features used by the model.
Suppose to execute a query with both logging and reranking, where the logging store is the same as the model store.
Suppose the model store contains 200 features while the model uses just half of them.
The logging will always consider all the 200 features of the store.
There is no possibility of printing only the 100 features used by the model.
Solution
An external parameter logAll has been added to the features transformer in order to give the user the possibility to choose how many features to log.
The new parameter has been added to:
Tests
Several tests have been added into org/apache/solr/ltr/feature/TestFeatureLogging.java
We add one test for each feature logger store - logAll parameter combination.
We checked that the set of features returned is the expected on (all the features in the store or only the model features).
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.