SOLR-16773: UI: Cloud>Nodes screen fix display of cores with non-standard shard names #1593
Conversation
…ames Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
| core.collection = collection.name; | ||
| core.shard = shard.name; | ||
| core.shard_state = shard.state; | ||
| core.label = core['collection'] + "_" | ||
| + (core['shard'] + "_").replace(/shard(\d+)_/, 's\$1') | ||
| + core['replica'].replace(/replica_?[ntp]?(\d+)/, 'r\$1'); |
There was a problem hiding this comment.
I think could be made a bit clearer as to what is going here in the GitHub description, e.g. super imposing a box on what has changed or a before/after, which is somewhat standard for UI. Alternatively, you could show how some of the names were treated in the past and how they will be treated going forward. Otherwise, mostly looks good.
However, I know this is in maintenance mode.
There was a problem hiding this comment.
My only question is, what is the ntp here for? I'm assuming NRT, Pull, and TLog replicas?
There was a problem hiding this comment.
Are there any reasons why we would not do any processing whatsoever of the shard names and simply show them as they were named? I assume there are some other screens or other confusion that could arise, but I am trying to doubly check that I understand the approach here fully.
There was a problem hiding this comment.
The label is for display purpose only. There is no before/after. This code produces exactly same display label as previously, but now also works for the custom shard names in implicit mode.
There was a problem hiding this comment.
Yes, ntp is replica type.
There was a problem hiding this comment.
Does the test failure have anything to do with the change? It doesn't seem like it.
There was a problem hiding this comment.
so, when implicit mode what would happen before this change?
After, it will show up. It would be helpful to know if (1) there was a particular error, (2) didn't show up at all, (3) was a broken page, etc.
There was a problem hiding this comment.
so, when implicit mode what would happen before this change?
The label would be ok, but we’d use wrong key for fetching metrics and get empty values in UI.
https://issues.apache.org/jira/browse/SOLR-16773
