MINOR: Fix typos in org.apache.solr.core package
#1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhludnev
approved these changes
May 7, 2023
janhoy
approved these changes
May 7, 2023
|
Thanks for the reviews - please feel free to merge this at your earliest convenience, as it seems I don't have access to do so myself. |
MarcusSorealheis
requested changes
May 8, 2023
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepositoryFactory.java
Outdated
Show resolved
Hide resolved
…upRepositoryFactory.java same capitalization
|
I pushed the changes up so I don't hold it up. @AndreyBozhko thanks for the contribution and I look forward to more in the future. |
|
@AndreyBozhko can you add an entry in |
This reverts commit 07533d6.
|
Thanks @MarcusSorealheis for the suggestion, I added a CHANGES entry. |
|
This should be backported to 9.3, no reason to keep it just for |
|
I'll back port next week. |
HoustonPutman
pushed a commit
that referenced
this pull request
Jul 27, 2023
* solr core - fix typos * solr core - fix typos * solr core - fix typos * run ./gradlew tidy * Update solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepositoryFactory.java same capitalization * a few typos. * add CHANGES entry * revert "add CHANGES entry" This reverts commit 07533d6. * add CHANGES entry --------- Co-authored-by: Marcus <marcuseagan@gmail.com> (cherry picked from commit 810783d)
HoustonPutman
added a commit
that referenced
this pull request
Jul 27, 2023
|
backported to 9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a number of typos in
org.apache.solr.corepackage - mostly in javadoc and comments.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.