-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16766: Remove -usage as option, and ensure both -help and -h work #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
in the not too distant future, I think all that detailed "help" information is going to move to the Ref Guide, and we'll only have the help that the commons-cli (or the other tool that @elyograg found) being generated in bin/solr -h... That way we can put all the tips and tricks and examples in one place, the Ref Guide! See SOLR-15831. |
It would be great to make sure that all the text improvements that you get when you run a |
I was a bit uncertain to add all of the options to the ref guide as well (for example all the |
I think so.... We should point users to the ref guide for detailed help information when using our various bin/solr XXX tools... Otehrwise, what we see is that we duplicate content and it gets out of alignment... |
a good example is how the |
So you suggest to add everything to the ref guide and change the help of the tools to a link which points the users to the corresponding ref guide paragraph instead of having the whole description duplicated? |
https://issues.apache.org/jira/browse/SOLR-16766
Description
Nowhere do we mention
-usage
as a parameter, and it's not one that I ever use.-help
is common, as is-h
, so make sure that works everywhere. There are places where-h
doesn't work!Solution
Deleted appearances of
-usage
and added-h
where it was not present. Also made some "beautification" here and there to make the help more consistent and complete.Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.