SOLR-16784 Frequent failing CollectionReloadTest #1662
Conversation
|
@gerlowskija just checking / reminding myself -- these big changes in V2 API are not expected to be backwards-compatible; right? |
There was a problem hiding this comment.
LGTM. Thanks @stillalex for fixing the test that I helped bring in, and then we had to BadApple it! I felt bad about it ;-)
|
Yep, @dsmiley ! The v2 API is "experimental" so that we can change it without deference to backcompat. Of course, if a PR meant to update a v2 API breaks the corresponding v1, that'd still be an issue/violation. But breaking changes to v2 are "expected". |
| @@ -128,7 +128,7 @@ public void tearDown() throws Exception { | |||
| @Repeat(iterations = 30) | |||
| public void testCreateDelete() throws Exception { | |||
| try { | |||
| switch (2 /*random().nextInt(3)*/) { | |||
| switch (random().nextInt(3)) { | |||
There was a problem hiding this comment.
[+1] This line by Alex fixes a mistake I made here. I commented it out while testing a PR a week or two back, and it accidentally got added to my PR and merged.
Good catch Alex!
|
Thank you @stillalex for this! |
* SOLR-16784 Frequent failing CollectionReloadTest * enabling random selection in TestPullReplica
|
thanks @epugh for merging! |
* SOLR-16784 Frequent failing CollectionReloadTest * enabling random selection in TestPullReplica
https://issues.apache.org/jira/browse/SOLR-16784
Description
Test was failing with 404 due to incorrect api calls every time the random picker chose '2'. I updated the urls and payload to the correct version and now it works.
I'm also taking the opportunity to fix one minor accidental change in TestPullReplica test class.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.