Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16823: mark as deprecated the bin/solr zk -upconfig equivalents of bin/solr zk upconfig #1668

Merged
merged 1 commit into from
May 30, 2023

Conversation

epugh
Copy link
Contributor

@epugh epugh commented May 27, 2023

https://issues.apache.org/jira/browse/SOLR-16823

Description

echo out to users that -upconfig should be upconfig for the various zk commands.

Solution

I will commit and backport to 9x, and remove the support from main.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh epugh requested a review from risdenk May 27, 2023 14:41
@epugh epugh merged commit b2361c0 into apache:main May 30, 2023
5 checks passed
epugh added a commit that referenced this pull request May 30, 2023
@epugh
Copy link
Contributor Author

epugh commented May 30, 2023

I didn't add a changelog entry thinking this was too minor..

epugh added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants