SOLR-16823: remove the old backcompat formats for bin/solr zk -upconfig and -downconfig

[epugh]

https://issues.apache.org/jira/browse/SOLR-16823

Description

Remove the bin/solr and bin/solr.cmd zk -upconfig and -downconfig special handling in favour of the standard bin/solr zk upconfig and bin/solr zk downconfig commands.

Solution

Remove special handling logic. This is only meant to be committed to main.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide

[epugh]

Stuck on figuring out a windows box to test the solr.cmd changes ;-). Maybe my teen will let me use his gaming rig for testing?

[epugh]

@Willdotwhite this is the small change to solr.cmd that I think is good to go but I can't validate!

[Willdotwhite]

Cheers @epugh ! I'll take a look at replicating this and update in a bit before I look at #1670 👍🏻

[Willdotwhite]

I've not actually got ZK set up for this example, I thought a less-verbose output showing that -upconfig and -downconfig no longer function would be best; is this ok to validate your expected behaviour on Windows (Windows 10.0.19045 Build 19045)?

upconfig:

PS C:\Users\Will\Projects\solr\solr\bin> .\solr.cmd zk upconfig -d . -n test -z localhost:1234   
Error: Could not find or load main class org.apache.solr.cli.SolrCLI    
Caused by: java.lang.ClassNotFoundException: org.apache.solr.cli.SolrCLI

---

PS C:\Users\Will\Projects\solr\solr\bin> .\solr.cmd zk -upconfig -d . -n test -z localhost:1234
 ERROR: Invalid command specified for zk sub-command

 Usage: solr zk upconfig|downconfig -d <confdir> -n <configName> [-z zkHost]
        solr zk cp [-r] <src> <dest> [-z zkHost]
        solr zk rm [-r] <path> [-z zkHost]
        solr zk mv <src> <dest> [-z zkHost]
        solr zk ls [-r] <path> [-z zkHost]
        solr zk mkroot <path> [-z zkHost]

Type bin/solr zk -help for full usage help

downconfig:

PS C:\Users\Will\Projects\solr\solr\bin> .\solr.cmd zk downconfig -d . -n test -z localhost:1234
Error: Could not find or load main class org.apache.solr.cli.SolrCLI    
Caused by: java.lang.ClassNotFoundException: org.apache.solr.cli.SolrCLI

---

PS C:\Users\Will\Projects\solr\solr\bin> .\solr.cmd zk -downconfig -d . -n test -z localhost:1234
 ERROR: Invalid command specified for zk sub-command

 Usage: solr zk upconfig|downconfig -d <confdir> -n <configName> [-z zkHost]
        solr zk cp [-r] <src> <dest> [-z zkHost]                            
        solr zk rm [-r] <path> [-z zkHost]                                  
        solr zk mv <src> <dest> [-z zkHost]                                 
        solr zk ls [-r] <path> [-z zkHost]                                  
        solr zk mkroot <path> [-z zkHost]                                   
                                                                            
Type bin/solr zk -help for full usage help      

[epugh]

Your approach makes sense to me. Did I do something though to make that java.lang.ClassNotFoundException: org.apache.solr.cli.SolrCLI error happen? do the other more typical commands still work? Like solr.cmd start ?

[Willdotwhite]

No, sorry, that's me being lazy - that's from ./solr/solr/bin, and not ./solr/solr/packaging/build/dev/bin. so there's no compiled code. Running things properly looks like this:

PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd zk upconfig -d . -n test -z localhost:1234
WARN  - 2023-06-15 20:27:44.532; org.apache.solr.common.cloud.SolrZkClient; Using default ZkCredentialsInjector. ZkCredentialsInjector is not secure, it creates an empty list of credentials which leads to 'OPEN_ACL_UNSAFE' ACLs to Z
ookeeper nodes
Terminate batch job (Y/N)? Y
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd start
Java 17 detected. Enabled workaround for SOLR-16463
OpenJDK 64-Bit Server VM warning: JVM cannot use large page memory because it does not have enough privilege to lock pages in memory.
WARNING: A command line option has enabled the Security Manager
WARNING: The Security Manager is deprecated and will be removed in a future release
Waiting up to 30 seconds to see Solr running on port 8983
Started Solr server on port 8983. Happy searching!
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> 

[epugh]

Awesome... Okay, going to merge!