Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 #1701

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Jun 11, 2023

This PR contains the following updates:

Package Type Update Change
com.google.errorprone:error_prone_annotations (source) dependencies minor 2.18.0 -> 2.22.0

Release Notes

google/error-prone

v2.22.0: Error Prone 2.22.0

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #​3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #​3803.

New checks:

Bug fixes and improvements:

  • Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
  • Prevent SuggestedFixes#renameMethod from modifying return type declaration (#​4043)
  • Fix UnusedVariable false positives for private record parameters (#​2713)
  • When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#​2910)
  • CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#​4009)
  • UnusedVariable: exclude junit5's @RegisterExtension (#​3892)
  • Support running all available patch checks (#​947)
  • Upgrade java-diff-utils 4.0 -> 4.12 (#​4081)
  • Flag unused Refaster template parameters (#​4060)
  • Support @SuppressWarnings("all") (#​4065)
  • Prevent Refaster UMemberSelect from matching method parameters (#​2456)
  • MissingDefault : Don't require // fall out comments on expression switches (#​2709)
  • Skip UnnecessaryLambda findings for usages in enhanced for loops (#​2518)
  • Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#​3797)
  • Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#​2753)
  • UnusedMethod: Added exempting variable annotations (#​2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0

v2.21.1: Error Prone 2.21.1

Changes:

  • Handle overlapping ranges in suppressedRegions (fixes #​4040)
  • Add AddressSelection to discourage APIs that convert a hostname to a single address

Full Changelog: google/error-prone@v2.21.0...v2.21.1

v2.21.0: Error Prone 2.21.0

New Checkers:

Fixed issues: #​3976, #​3986, #​4001, #​4002, #​4026, #​4027

Full Changelog: google/error-prone@v2.20.0...v2.21.0

v2.20.0: Error Prone 2.20.0

Changes:

  • This release is compatible with early-access builds of JDK 21.

New Checkers:

Fixes issues: #​2232, #​2243, #​2997, #​3301, #​3843, #​3903, #​3918, #​3923, #​3931, #​3945, #​3946

Full Changelog: google/error-prone@v2.19.1...v2.20.0

v2.19.1: Error Prone 2.19.1

This release fixes a binary compatibility issue when running on JDK 11, see #​3895

Full Changelog: google/error-prone@v2.19.0...v2.19.1

v2.19.0: Error Prone 2.19.0

New Checkers:

Fixes issues: #​956, #​3504, #​3654, #​3703, #​3731, #​3737, #​3760, #​3779, #​3796, #​3809, #​3813

Full Changelog: google/error-prone@v2.18.0...v2.19.0


Configuration

📅 Schedule: Branch creation - "* * * * 0" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from 58da93a to 4c7726e Compare June 11, 2023 03:09
@risdenk
Copy link
Contributor

risdenk commented Jun 14, 2023

not sure why the previous one was closed

#1642

Copy link
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NotJavadoc](https://errorprone.info/bugpattern/NotJavadoc)
[StringCaseLocaleUsage](https://errorprone.info/bugpattern/StringCaseLocaleUsage)
[UnnecessaryTestMethodPrefix](https://errorprone.info/bugpattern/UnnecessaryTestMethodPrefix)

need to evaluate these new rules and add to gradle/validation/error-prone.gradle either enabling or disabling them.

@solrbot solrbot force-pushed the renovate/com.google.errorprone branch 2 times, most recently from 5180b7e to 50ed3af Compare June 15, 2023 01:22
@solrbot solrbot changed the title Update dependency com.google.errorprone:error_prone_annotations to v2.19.1 Update dependency com.google.errorprone:error_prone_annotations to v2.20.0 Jun 21, 2023
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from 50ed3af to 11d0d7f Compare June 21, 2023 16:23
@risdenk
Copy link
Contributor

risdenk commented Jun 23, 2023

Need to evaluate these rules too:

[InlineTrivialConstant](https://errorprone.info/bugpattern/InlineTrivialConstant)
[UnnecessaryStringBuilder](https://errorprone.info/bugpattern/UnnecessaryStringBuilder)
[BanClassLoader](https://errorprone.info/bugpattern/BanClassLoader)
[DereferenceWithNullBranch](https://errorprone.info/bugpattern/DereferenceWithNullBranch)
[DoNotUseRuleChain](https://errorprone.info/bugpattern/DoNotUseRuleChain)
[LockOnNonEnclosingClassLiteral](https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral)
[MissingRefasterAnnotation](https://errorprone.info/bugpattern/MissingRefasterAnnotation)
[NamedLikeContextualKeyword](https://errorprone.info/bugpattern/NamedLikeContextualKeyword)
[NonApiType](https://errorprone.info/bugpattern/NonApiType)

@risdenk risdenk self-assigned this Jun 23, 2023
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from 11d0d7f to 177e543 Compare June 23, 2023 14:19
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from 177e543 to e45a63b Compare August 6, 2023 20:21
@solrbot solrbot changed the title Update dependency com.google.errorprone:error_prone_annotations to v2.20.0 Update dependency com.google.errorprone:error_prone_annotations to v2.21.0 Aug 6, 2023
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from e45a63b to 893227b Compare August 9, 2023 22:23
@solrbot solrbot changed the title Update dependency com.google.errorprone:error_prone_annotations to v2.21.0 Update dependency com.google.errorprone:error_prone_annotations to v2.21.1 Aug 9, 2023
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from 893227b to dfac087 Compare September 15, 2023 08:27
@janhoy janhoy mentioned this pull request Sep 23, 2023
1 task
@solrbot solrbot changed the title Update dependency com.google.errorprone:error_prone_annotations to v2.21.1 Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 Sep 26, 2023
@solrbot solrbot force-pushed the renovate/com.google.errorprone branch from dfac087 to 4370380 Compare September 26, 2023 20:21
@risdenk
Copy link
Contributor

risdenk commented Oct 2, 2023

I'm looking at this today

Copy link
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the added rules and disabled ones we don't need. I fixed a few failures that were minor.

@risdenk
Copy link
Contributor

risdenk commented Oct 2, 2023

Hmmm well apparently locally didn't end up recompiling all the tests so doing that now :D

@solrbot
Copy link
Collaborator Author

solrbot commented Oct 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@risdenk risdenk merged commit 0bdf356 into apache:main Oct 2, 2023
3 checks passed
risdenk added a commit that referenced this pull request Oct 2, 2023
….22.0 (#1701)

* Update dependency com.google.errorprone:error_prone_annotations to v2.22.0

Co-authored-by: Kevin Risden <krisden@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants