SOLR-16860: Remove collection -> synthetic core mapping in Coordinator Node upon collection deletion #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llection deletion
justinrsweeney
approved these changes
Jul 5, 2023
|
@patsonluk Can you include updates to CHANGES.txt for this Jira: https://issues.apache.org/jira/browse/SOLR-16860 in the 9.3.0 section? |
Ah thank you for the reminder! fedbee2 |
justinrsweeney
added a commit
that referenced
this pull request
Jul 6, 2023
…r Node upon collection deletion (#1754) * CoordinatorHttpSolrCall should remove collection from mapping upon collection deletion * Updated CHANGES.txt --------- Co-authored-by: Justin Sweeney <justinsweeney@fullstory.com>
justinrsweeney
added a commit
to cowpaths/fullstory-solr
that referenced
this pull request
Jul 6, 2023
…r Node upon collection deletion (apache#1754) * CoordinatorHttpSolrCall should remove collection from mapping upon collection deletion * Updated CHANGES.txt --------- Co-authored-by: Justin Sweeney <justinsweeney@fullstory.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16860
Description
Similar to #1752 , the mapping of collection -> synthetic core should be removed from Coordinator Node upon collection deletion. Otherwise query to such deleted collection would not throw
SolrExceptionofCollection not found.Solution
Remove the collection from
collectionVsCoreNameMappingon zk notification on collection removalTests
Added extra test condition in
AddWatchChecklist
Please review the following and check all that apply:
mainbranch../gradlew check.