SOLR-16803: Remove dependencies on SimplePostTool from Solr Core classes.. #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
requested changes
Jul 24, 2023
| import java.nio.BufferOverflowException; | ||
| import java.nio.ByteBuffer; | ||
|
|
||
| public class BinaryUtils { |
There was a problem hiding this comment.
There is similar code in
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BinaryRequestWriter.java:87: public static class BAOS extends ByteArrayOutputStream {
Might make sense to use this class there as well?
There was a problem hiding this comment.
I made the change to combine them in c486782, and it ended up being a bit more intrusive then I expected. All tests pass. Can you give it a quick look?
|
Great feedback @risdenk, especially on coming up with a better name ;-) |
…tils Required a move to the solrj/../common package in order to be used by solrj and core modules.
dsmiley
reviewed
Jul 27, 2023
solr/solrj/src/java/org/apache/solr/common/InputStreamUtils.java
Outdated
Show resolved
Hide resolved
epugh
added a commit
that referenced
this pull request
Jul 31, 2023
…ses.. (#1805) Classes through solr/core and solr/solrj depended on methods defined in the SimplePostTool, a auxillary class that isn't really "part" of the core Solr offering. Relocate those methods to the common Utils.java class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16803
Description
Over time various classes through out Solr have dependencies on methods in the SimplePostTool class. However, this is sort of an ancillary class, and it shouldn't be relied upon.
Solution
Extract methods that are used into a new BinaryUtils.java file. I could also see the three methods being added to the existing "Utils.java" too....
Tests
Rerunning tests and bats.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.