SOLR-16906: Correctly capture REPLICATION metrics in Prometheus config #1809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16906
Description
The Prometheus exporter config provided with Solr seems to unintentionally ignore replication-related metrics. This change lets the Prometheus exporter correctly collect/expose them.
Solution
Fix the regex that intends to match REPLICATION category metrics. REPLICATION metrics start with
REPLICATION./replication
, but the previous regex misses the/
(slash) and fails to match them.Tests
Start a
solr-exporter
process and make a request tohttp://localhost:9983/metrics
and confirm metrics such assolr_metrics_core_replication_leader
orsolr_metrics_core_requests_total{category="REPLICATION"}
show up.Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.