Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16876: Remove extra /solr from calls that generates extra WARNING in logs #1833

Merged
merged 8 commits into from
Jan 10, 2024
Merged

SOLR-16876: Remove extra /solr from calls that generates extra WARNING in logs #1833

merged 8 commits into from
Jan 10, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Aug 9, 2023 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-16876

Description

We currently get the WARNING: URLs provided to this tool needn't include Solr's context-root (e.g. "/solr"). Such URLs are deprecated and support for them will be removed in a future release. Correcting from [http://localhost:8983/solr] to [http://localhost:8983] when using the tool.

Solution

Remove the /solr from the urls.

Tests

new lifecycle test!

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh epugh marked this pull request as draft August 9, 2023 23:39
@epugh epugh changed the title SOLR-16876: Move arg parsing into Java SOLR-16876: Move Auth arg parsing into Java Aug 9, 2023
@epugh epugh changed the title SOLR-16876: Move Auth arg parsing into Java SOLR-16876: Move bin/solr auth command argument parsing into Java code Aug 10, 2023
@epugh epugh changed the title SOLR-16876: Move bin/solr auth command argument parsing into Java code SOLR-16876: Remove extra /solr from calls that generates extra WARNING in logs Jan 9, 2024
@epugh epugh marked this pull request as ready for review January 9, 2024 15:32
@epugh
Copy link
Contributor Author

epugh commented Jan 9, 2024

I'd like to get this merged before tackling the next step of SOLR-16876....

gerlowskija
gerlowskija approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epugh epugh merged commit 81b81f0 into apache:main Jan 10, 2024
4 checks passed
epugh added a commit that referenced this pull request Jan 10, 2024
@epugh
SOLR-16876: Remove extra /solr from calls that generates extra WARNIN…
5d1c283 
…G in logs (#1833)

Adds a bats test of the full lifecycle of enabling/disabling auth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerlowskija gerlowskija gerlowskija approved these changes

@HoustonPutman HoustonPutman Awaiting requested review from HoustonPutman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@epugh @gerlowskija