-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16935 Add spans to cover gaps in query processing #1853
base: main
Are you sure you want to change the base?
Conversation
Span Data Review All requests currently have the root span:
New child spans covering more of the request processing, added with this PR. these spans are present on all requests not just Query
@janhoy this is a list of tags we export. I am thinking it might be a good idea to add it to the ref guide? |
d0af94c
to
dba3157
Compare
converted to draft so no one accidentally merges this. the PR is waiting review from @dsmiley and potentially some contributions, as requested on the Jira ticket. |
b269860
to
90ab034
Compare
90ab034
to
62bcb96
Compare
62bcb96
to
844ea6b
Compare
844ea6b
to
a30f6cf
Compare
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
https://issues.apache.org/jira/browse/SOLR-16935
Description
This is a followup of #1841 where I am proposing 2 new spans for query processing, to close some of the unknown gaps in the duration.
Will do a complete review of all spans we are emitting too.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.