SOLR-16925 Broken JSON indentation using JacksonJsonWriter #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
requested changes
Sep 20, 2023
There was a problem hiding this comment.
I'm not really sure how this fixing the issue (I also tested and the issue is still there). We are already using a pretty printer, but the issue is that the pretty printer is stateful.
So basically we need to create a new instance of PrettyPrinter for every json serialization, which we can do by using the gen.setPrettyPrinter(pretty.createInstance()) method if pretty is a DefaultPrettyPrinter object.
|
I created a new PR for this #1942 |
|
I'm sure it did fix the issue. Your solution works just fine. I'll close this and approve that |
|
closing this in favor of #1942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.