SOLR-17042: Remove V2RequestSupport interface #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially intended as a way to allow dog-fooding of v2 APIs by converting v1 requests into their v2 counterparts, V2RequestSupport never received the adoption it needed to get traction within the codebase. It was only ever implemented for a small set of "collection admin" APIs, and was superceded by our current approach in SolrJ of generating v2 SolrRequest implementations from our "OAS". This commit removes the interface, and two associated SolrRequest methods, from SolrJ.
|
Nice bit of clean up. Makes me sad we can't just remove it altogether if no api's are currently using it.... |
Yeah, agreed. But the cost is pretty low, so it's not a huge deal either way 🤷 This is the first of a few improvements I have in mind to how SolrJ inspects and decides how to route requests. Obviously there'll be a gap between 9.x and 10 for backcompat, but the cumulative effect on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17042
Description
Initially intended as a way to allow dog-fooding of v2 APIs by converting v1 requests into their v2 counterparts, V2RequestSupport never received the adoption it needed to get traction within the codebase. It made most sense in a world where all v2 APIs had clear v1 counterparts, and was only ever implemented for a small set of "collection admin" APIs at the peak of its adoption.
It currently has 0 implementations and should be removed from Solr, as it's largely been superceded by the newer approach of generating distinct v2 SolrRequest implementations from our OAS.
Solution
This commit removes the V2RequestSupport interface and two associated SolrRequest methods on the
mainbranch. (Upon merging, a corresponding set of deprecation notices will be added tobranch_9xto keep this in line with our backcompat policy.)Tests
Existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.