SOLR-17057: JSON Query regression of defType #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "query" is specified with a String (not JSON structure), "defType" should parse it. Since 9.4 defType was ignored.
|
+1 for a 9.4.1 release for this issue. I was just upgrading the code for the upcoming AI-Powered Search book, and the most of the book's query examples are now returning no results due to this issue: treygrainger/ai-powered-search#78 Works fine up through Solr 9.3, but most queries are broken with 9.4.0 since we use the edismax query parser through the JSON DSL for most queries. |
# Conflicts: # solr/CHANGES.txt
# Conflicts: # solr/CHANGES.txt
dsmiley
added a commit
that referenced
this pull request
Dec 5, 2023
If "query" is specified with a String (not JSON structure), "defType" should parse it. Since 9.4, defType was ignored. Ignoring defType should have been conditional on the query being JSON structured.
dsmiley
added a commit
that referenced
this pull request
Dec 5, 2023
If "query" is specified with a String (not JSON structure), "defType" should parse it. Since 9.4, defType was ignored. Ignoring defType should have been conditional on the query being JSON structured.
|
(a 9.4.1 will happen) |
|
Thank you @dsmiley ! |
|
Thanks, @dsmiley - looking forward to it! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "query" is specified with a String (not JSON structure), "defType" should parse it. Since 9.4 defType was ignored.
https://issues.apache.org/jira/browse/SOLR-17057