SOLR-17066: Add 'defaultCollection' to SolrClients #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a setter ('withDefaultCollection(String)') to all
SolrClient builders, and propagates the field down to each client
implementation. All SolrClient implementations now have a getter to
fetch this property ('getDefaultCollection').
NOTE: This commit doesn't actually have the clients use the new field
anywhere. That will happen in a separate commit, in hopes that
splitting up those two pieces across commit boundaries will make
backporting easier when the time comes.
dsmiley
approved these changes
Nov 14, 2023
|
I've been thinking a bit about how to get this change in. I imagine core-based URLs are pretty common in Solr - common enough that it'd be tough to switch them all over in this PR (or in any single PR). So my thought was that this PR could stay pretty narrowly targeted on introducing the SolrClient and Builder plumbing, and that subsequent SOLR-17066 PRs would handle switching over various SolrClient instantiations to use this new plumbing. Lmk if anyone can think of a better way to break this work up! |
|
Makes sense! |
dsmiley
approved these changes
Dec 15, 2023
gerlowskija
deleted the
SOLR-17066-add-default-collection-to-all-solrj-clients
branch
gerlowskija
added a commit
that referenced
this pull request
Dec 18, 2023
This commit adds a setter ('withDefaultCollection(String)') to all
SolrClient builders, and propagates the field down to each client
implementation. All SolrClient implementations now have a getter to
fetch this property ('getDefaultCollection').
This will help users replace the anti-pattern of baking the collection/
core name into their client's base URL to achieve a sort of "poor
man's" default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17066
Description
CloudSolrClient has long had a 'defaultCollection' property. This property acts as a default, saving users who only interact with a single core from still needing to specify its name repetitiously. Unfortunately, this nicety is missing from many other client implementations.
Solution
This PR adds
defaultCollectionas a protected field on the abstractSolrClientclass. It adds the required plumbing in "Builder" classes and client constructors to allow users to set the value. And of course it modifies therequest()implementation for each client to use the default when an explicit collection has not been specified.Tests
Tests are still needed and will be added prior to taking this out of 'draft' mode.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.