SOLR-17094: Close ObjectCache when closing CoreContainer #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psalagnac
approved these changes
Dec 21, 2023
dsmiley
pushed a commit
that referenced
this pull request
Dec 23, 2023
Co-authored-by: Vincent Primault <vprimault@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17094
Description
In #2110 was introduced the capability for ObjectCache to close Closeable objects that were put in it. Unfortunately, despite itself implementing Closeable, the ObjectCache was never closed by CoreContainer when shutting down.
Solution
CoreContainer is now closing the ObjectCache when shutting down.
Tests
None
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.