SOLR-17066: Switch HttpSolrClient away from core URLs, pt 1 #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StreamingSolrClients now creates its internal clients using node base URLs (e.g. "host:8983/solr") and `withDefaultCollection`.
Providing a core URL as a SolrClient's "base URL" prevents it from communicating with other cores or making core-agnostic API requests (e.g. node healthcheck, list cores, etc.) This commit migrates production (i.e. non-test) code in the 'core' module to use the `withDefaultCollection` builder method in lieu of using core-based URLs directly.
epugh
reviewed
Jan 3, 2024
solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java
Outdated
Show resolved
Hide resolved
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Should SolrCLI.java's "normalizeSolrUrl" method be moved over to here, or reuse some of these methods???
There was a problem hiding this comment.
Yeah, I think that'd probably make sense (moving normalizeSolrUrl that is). We've got this nice class just for those sort of utilities, so might as well use it 🤷
The only hiccup I'd imagine that might cause is that it looks like nSU uses a static 'CLIO' object that SolrCLI has access to. But I'm sure there's ways to straighten that out...
gerlowskija
added a commit
that referenced
this pull request
Jan 14, 2024
Providing a core URL as a SolrClient's "base URL" prevents it from communicating with other cores or making core-agnostic API requests (e.g. node healthcheck, list cores, etc.) This commit migrates production (i.e. non-test) code in the 'core' module to use the `withDefaultCollection` builder method in lieu of using core-based URLs directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17066
Description
SOLR-17066 introduced a
withDefaultCollectionbuilder method that can be used in lieu of providing a core URL as a "base". (Core URLs are not ideal as they prevent clients from making core-agnostic requests.)However, Solr's own client usage still needs modified to use this new builder method.
Solution
This PR tackles this for the necessary production (i.e. non-test) code in Solr's "core" modules. SolrClient usage in tests and usage in other build modules (e.g. contribs, solrj, etc.) still need converted.
Tests
Existing tests continue to pass. New unit tests added in
URLUtilsTest.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.