Build: validation.git.failOnModified default to isCIBuild #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
approved these changes
Jan 15, 2024
uschindler
approved these changes
Jan 15, 2024
dsmiley
added a commit
that referenced
this pull request
Jan 15, 2024
dsmiley
deleted the
Build-validation.git.failOnModified-default-to-isCIBuild
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed: https://lists.apache.org/thread/08bf2772cmh9pnvk667v6995qnh4m2v4
Inlined failOrWarn so I could use a dynamic default depending on isCIBuild
I tested this with setting the env var and not, and with the property both ways.
I also slightly optimized isCIBuild .