Enable PRS for all cloud tests

[noblepaul]

WIP

[magibney]

Should we instead have this default at the lowest level to being randomized, or otherwise ensure that nothing (either now or future) falls through the cracks?

This would yield a much smaller diff, but more importantly: having the randomized/configurable default at a lower level would improve confidence that we're achieving the goal of test coverage for both PRS and non-PRS case. Ideally it'd be nice to only explicitly specify CollectionAdminRequest.setPerReplicaState(boolean) when a test is actually testing behavior that relies specifically on PRS or non-PRS.

Specifically, I'm wondering about changing this line:

--- a/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
@@ -684,7 +684,7 @@ public abstract class CollectionAdminRequest<T extends CollectionAdminResponse>
         addProperties(params, properties);
       }
       numReplicas.writeProps(params);
-      if (Boolean.TRUE.equals(perReplicaState)) {
+      if (perReplicaState == null ? DEFAULT_PRS : Boolean.TRUE.equals(perReplicaState)) {
         params.set(CollectionAdminParams.PER_REPLICA_STATE, perReplicaState);
       }
       params.setNonNull(ALIAS, alias);

... where DEFAULT_PRS would be a new boolean constant (or pseudo-constant) initialized via sysprop (analogous to current SolrCloudTestCase.USE_PER_REPLICA_STATE).

[noblepaul]

Should we instead have this default at the lowest level to being randomized, or otherwise ensure that nothing (either now or future) falls through the cracks?

I think we should explore that. We do have tests that do PRS on and off explicitly. It'll be better if we do something in the test framework level instead of SolrJ

[hiteshk25]

do we log somewhere whether collection has prs(or not)?

[github-actions]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!