SOLR-17066: Replace 'data store' term in code and docs #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Data store" as a term, was introduced a few weeks back as a way to
refer generically to something that could be either a collection or a
core. As its use expanded though, it turned out to not be very well
liked in practice.
This commit replaces all usage of the term with either "collection" or
"index type", depending on the specific usage.
(Or, to mangle a Chaucer quote:
"Now 'data store' was liked at first /
But felt stainèd on the morrow. /
And thus does Fortune's wheel so turn, /
Switching happiness for sorrow."
- Geoffrey Chaucer, Canterbury Tales)
github-actions
bot
added
documentation
dsmiley
reviewed
Jan 16, 2024
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java
Show resolved
Hide resolved
epugh
reviewed
Jan 16, 2024
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
Outdated
Show resolved
Hide resolved
epugh
approved these changes
Jan 16, 2024
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionRequiringSolrRequest.java
Outdated
Show resolved
Hide resolved
gerlowskija
added a commit
that referenced
this pull request
Jan 19, 2024
"Data store" as a term, was introduced a few weeks back as a way to refer generically to something that could be either a collection or a core. As its use expanded though, it turned out to not be very well liked in practice. This commit replaces all usage of the term with either "collection" or "index type", depending on the specific usage.
freedev
added a commit
to freedev/solr
that referenced
this pull request
Jan 26, 2024
* main: (27 commits) Update protected-branches to include branch_9_5 (apache#2211) SOLR-16397: Tweak v2 'REQUESTSTATUS' API to be more REST-ful (apache#2144) SOLR-17120: handle null value when merging partials (apache#2214) SOLR-17119: Fix exception swallowing in /cluster/plugins (apache#2202) SOLR-15960 Cut over System.getProperty() to EnvUtils for modules (apache#2193) Final fix for node problems (apache#2208) SOLR-16397: Fix warning in merge-indices docs Fix nodeSetup, use node distBaseUrl instead of registry (apache#2208) Add next minor version 9.6.0 SOLR-17089: Upgrade Jersey to 3.1.5 (apache#2178) solr-ref-guide: fix typo in result-clustering.adoc (apache#2210) SOLR-17074: Fixed not correctly escaped quote in bin/solr script (apache#2200) SOLR-15960: Rename getProp as getProperty (apache#2194) Add npmRegistry for nodeSetup as well (apache#2208) Give NPM registry option for downloading node tools (apache#2208) SOLR-17116: Fix INSTALLSHARDDATA async reporting (apache#2188) SOLR-17066: Replace 'data store' term in code and docs (apache#2201) SOLR-17121: Fix SchemaCodecFactory to get PostingsFormat and DocValues from field. (apache#2206) Sync CHANGES for 9.4.1 Add bugfix version 9.4.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17066
Description
"Data store" as a term, was introduced a few weeks back as a way to refer generically to something that could be either a collection or a core. As its use expanded though, it turned out to not be very well liked in practice. @dsmiley and @epugh in particular suggested we start using "collection" in a more generic sense to refer to any sort of "logical index" (regardless of whether it's a single core or a distributed collection in actuality).
Solution
This PR replaces "data store" and the related term "store type", with "collection" and "index type" respectively.
The "Glossary" in our ref-guide has been updated to clarify that "collection" can be used to refer to both cores and collections.
Tests
N/A - existing tests continue to pass, but otherwise this is an IDE refactor/rename that doesn't add or remove any functionality.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.