SOLR-17066: Switch Http2SolrClient away from coreURLs #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing a core URL as a SolrClient's "base URL" prevents it from communicating with other cores or making core-agnostic API requests (e.g. node healthcheck, list cores, etc.) This commit migrates all Http2SolrClient usage away from core URLs.
epugh
approved these changes
Feb 8, 2024
| @@ -89,9 +90,16 @@ public void runImpl(CommandLine cli) throws Exception { | |||
| } | |||
|
|
|||
| public void runCommand(String baseUrl, String root, String credentials) throws IOException { | |||
| if (URLUtil.isBaseUrl(baseUrl)) { | |||
There was a problem hiding this comment.
this is interesting.. I wonder if "url" is a good name for this parameter? I like the check... --collection-url? -collection-url.. though we dont have any other commands with a - in the name.... at least we have the check.
gerlowskija
added a commit
that referenced
this pull request
Feb 13, 2024
Providing a core URL as a SolrClient's "base URL" prevents it from communicating with other cores or making core-agnostic API requests (e.g. node healthcheck, list cores, etc.) This commit migrates all Http2SolrClient usage away from core URLs.
jdyer1
added a commit
to jdyer1/solr
that referenced
this pull request
Feb 20, 2024
jdyer1
added a commit
to jdyer1/solr
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17066
Description
SOLR-17066 introduced a
withDefaultCollectionbuilder method that can be used in lieu of providing a core URL as a "base". (Core URLs are not ideal as they prevent clients from making core-agnostic requests.)However, Solr's own client usage still needs modified to use this new builder method.
Solution
This commit migrates Http2SolrClient away from core URLs and towards using
withDefaultCollection. This (along with #2254) are the last vestiges of core URLs in Solr!Tests
Tests continue to pass. No additional tests as this is "just" a refactor.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.