Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl #2311

Merged
merged 1 commit into from Apr 30, 2024
Merged

SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl #2311

merged 1 commit into from Apr 30, 2024

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Feb 27, 2024

@github-actions GitHub Actions
Copy link

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Apr 30, 2024
@epugh
Copy link
Contributor

epugh commented Apr 30, 2024

Seems fine... Worth committing?

epugh
epugh approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I mean, I hate that we have to trim things on a one by one basis, it just seems like something "we shouldn't ahve to thing about".. But, I guess if I am going to complain about whitespace, I should also argue about the existence of Null in Java and NullPointerExceptions too!

@janhoy
Copy link
Contributor Author

janhoy commented Apr 30, 2024

Yea, looks quite safe. Won't fix any whitespace issues in solrconfig.xml but this does not seem to have been a huge issue these last 10 years either. Will merge.

@janhoy janhoy merged commit 033be0f into apache:main Apr 30, 2024
4 checks passed
@janhoy janhoy deleted the SOLR-6572-trim-whitespace-solrconfig branch April 30, 2024 16:48
janhoy added a commit that referenced this pull request Apr 30, 2024
@janhoy
SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl (#2311)
8b4f57a 
(cherry picked from commit 033be0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

Assignees
No one assigned
Labels
client:solrj stale PR not updated in 60 days
Projects
None yet
Milestone
No milestone
2 participants
@janhoy @epugh