SOLR-17184: Fixing sorting order of documents for comparison in PeerSyncTest to avoid random failures #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yncTest to avoid random failures
risdenk
approved these changes
Feb 28, 2024
justinrsweeney
added a commit
that referenced
this pull request
Feb 28, 2024
…yncTest to avoid random failures (#2317) * SOLR-17184: Fixing sorting order of documents for comparison in PeerSyncTest to avoid random failures * Tidying code
janhoy
pushed a commit
to solrbot/apache-_-solr
that referenced
this pull request
Feb 29, 2024
…yncTest to avoid random failures (apache#2317) * SOLR-17184: Fixing sorting order of documents for comparison in PeerSyncTest to avoid random failures * Tidying code
dsmiley
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17184
Description
This is a small fix for an issue with PeerSyncTest where it would randomly fail due to the order of documents returned.
Solution
Added a secondary sort on id for the queries to ensure consistent ordering.
Tests
Using existing tests.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.