SOLR-17232: PropertiesOutputStream overrides write(byte[], int, int). #2400
Conversation
|
Some JavaDocs on this class would be nice.. I looked at it, and I still don't quite grok why it is needed for a properties file? |
|
I think PropertiesOutputStream could be renamed IndexOutputOutputStream because it is used to wrap an IndexOutput to expose it as an OutputStream. |
|
Lets rename this in main; separate no-JIRA PR. |
|
The name "IndexOutputOutputStream", while slightly funny, is fine, with just a bit of docs to highlight what you said "wrap an IndexOutput to expose it as an OutputStream" would have helped me grok it! |
|
Renamed. It was used only in two internal locations. |
| @@ -20,11 +20,12 @@ | |||
| import java.io.OutputStream; | |||
| import org.apache.lucene.store.IndexOutput; | |||
|
|
|||
| public class PropertiesOutputStream extends OutputStream { | |||
| /** Wraps an {@link IndexOutput} to expose it as an {@link OutputStream}. */ | |||
There was a problem hiding this comment.
thank you! Helps me understand what it's for (and why the double "Output" in the name!)...
bruno-roustant
force-pushed
the
prop_stream
branch
from
96252c6
to
b6e8bc6
Compare
https://issues.apache.org/jira/browse/SOLR-17232