Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses CHANGES.txt to identify contributors #2424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Apr 26, 2024

This script can be used to list contributors as indicated in CHANGES.txt so that we can easily thank them in our release notes.

I tested it on 9.6 and I'm happy with the results! Added them to: https://cwiki.apache.org/confluence/display/SOLR/ReleaseNote9_6_0

Ideally we incorporate this into the Release Wizard.

@dsmiley dsmiley requested a review from janhoy April 26, 2024 21:08
@dsmiley
Copy link
Contributor Author

dsmiley commented Apr 26, 2024

Unlike a Git log, CHANGES.txt has cleaner data and can be edited if we see a formatting or spelling glitch. For better or worse (?), it doesn't have more trivial changes that were not worthy of CHANGES.txt.


del contributors['solrbot']

sorted_contributors = sorted(contributors.items(), key=lambda item: item[1], reverse=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious that the list is sorted by most contributions, so perhaps better to do a lexical sort?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wether it's obvious or not, is this a problem? It's just a list of people to thank.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what it looks like: LMK if it should change https://solr.staged.apache.org/news.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A smaller font would be nice... kind of like credits so as to not distract from the primary message of what the release is. Maybe centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants