SOLR-17066 Fix ShardSplitTest & StressHdfsTest #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify getBaseURL
github-actions
bot
added
test-framework
client:solrj
module:hdfs
tests
cat:cloud
labels
gerlowskija
approved these changes
May 13, 2024
|
I'm going to merge this even though not all tests are fixed in ShardSplitTest. At least the ones introduced by SOLR-17066 are. Sadly there are still more failures that seemed to have been introduced earlier, like org.apache.solr.cloud.api.collections.ShardSplitTest.testSplitStaticIndexReplication starting 2023-11 which I'm looking in to. |
dsmiley
added a commit
that referenced
this pull request
May 14, 2024
Clarify getBaseURL (cherry picked from commit d141875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOLR-17066 broke some tests marked Nightly since the beginning of February; they didn't fail previously then they fail always. It's so sad we don't have mechanisms to bring our attention to something that is so glaring. I just happened to be looking at build failures, and I saw so many and I started looking at them.
http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.api.collections.ShardSplitTest.test
https://ge.apache.org/scans/tests?search.rootProjectNames=*solr*&search.timeZoneId=America%2FNew_York&tests.container=org.apache.solr.cloud.api.collections.ShardSplitTest&tests.help=executedTest&tests.test=test
Even though SOLR-17066 shipped, I'm nonetheless doing a PR against the same issue because I basically just fixed tests.