Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16505: Add auth listener to RecoveryStrategy SolrClient #2462

Conversation

iamsanjay
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-16505

As previously noticed that whenever we re-create Solr client using existing Http2SolrClient then no listeners were passed to the new Http2SolrClient object. To fix this, a new code(withListenerFactory method in Http2SolrClient#Builder class) is added to previous commit for SOLR_16505. However, It did not called this new method for client in RecoveryStrategy. Therefore all the calls that were made from RecoveryStrategy were failing in case if auth is enabled.

Tests

A new test case is added to configure SolrCloud with a security.json file. A specific test condition is tested where after indexing good amount of document, a new replica is added which would trigger RecoveryStrategy for it and everything is happening when auth is enabled.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@iamsanjay iamsanjay changed the title SOLR-16505: Add auth listener to recovery client SOLR-16505: Add auth listener to RecoveryStrategy SolrClient May 15, 2024
@iamsanjay
Copy link
Contributor Author

#2467 is a better fix!

@iamsanjay iamsanjay closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant