SOLR-17275: Major performance regression of CloudSolrClient in Solr 9.6.0 when using aliases #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for reverting this piece. I think we'll come back to it later when we have more time to reconsider it. I strongly suspected the root cause was an extra ZK interaction but your testing & code sleuthing suggested it's actually the |
|
Can you please update CHANGES.txt under 9.6.1 bug fix, maybe say:
|
dsmiley
reviewed
May 16, 2024
dsmiley
reviewed
May 16, 2024
# Conflicts: # solr/CHANGES.txt
dsmiley
pushed a commit
that referenced
this pull request
May 16, 2024
SolrJ ZkClientClusterStateProvider: revert SOLR-17153 for perf regression when aliases are used. Other parts of that issue are not reverted. Affects only Solr 9.6. Thanks Rafał Harabień for reporting the problem. (cherry picked from commit f073dc8)
dsmiley
pushed a commit
that referenced
this pull request
May 16, 2024
SolrJ ZkClientClusterStateProvider: revert SOLR-17153 for perf regression when aliases are used. Other parts of that issue are not reverted. Affects only Solr 9.6. Thanks Rafał Harabień for reporting the problem. (cherry picked from commit f073dc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17275
Description
A recent change, as part of SOLR-17153 to ZkClusterStateProvider caused CloudSolrClient (zk based) to force update collection in local cluster state for aliases, which indeed caused a performance regression. Verified this using a test
Solution
Partially reverted the change from SOLR-17153 that caused the regression (behavior on the client side should be fully reverted)
Tests
Verified that all tests pass. Used a test locally to understand whether the regression specifically triggers a ZK getData - which did not happen before and after.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.