SOLR-17275: Major performance regression of CloudSolrClient in Solr 9.6.0 when using aliases #2463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17275
Description
A recent change, as part of SOLR-17153 to ZkClusterStateProvider caused CloudSolrClient (zk based) to force update collection in local cluster state for aliases, which indeed caused a performance regression. Verified this using a test
Solution
Partially reverted the change from SOLR-17153 that caused the regression (behavior on the client side should be fully reverted)
Tests
Verified that all tests pass. Used a test locally to understand whether the regression specifically triggers a ZK getData - which did not happen before and after.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.