SOLR-14457: Fix closing of malformed GZIPInputStream #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrob
reviewed
Sep 2, 2021
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpClientUtilTest.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java
Show resolved
Hide resolved
madrob
reviewed
Sep 3, 2021
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java
Show resolved
Hide resolved
madrob
reviewed
Sep 3, 2021
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java
Outdated
Show resolved
Hide resolved
madrob
approved these changes
Sep 3, 2021
|
Sorry for joining late to the PR but I think that removing the interceptor entirely would be a better solution. The current HTTP Client version handles the compression itself when the right headers are present in the response, handling also the errors properly. What do you think if I open a new improvement issue to remove that piece of code completely? (less code to maintain 😀) |
|
@samuelgmartinez , Thanks for the input! I think that would be great to go as a new improvement ticket, and we will probably shoot for 9.0 (not 8.x) if we decide to go that direction. |
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14457
Cleaned up the way that
GZIPInputStreamobjects are created, since I think the current manner doesn't work whenGzipDecompressingEntity.getContent()is called multiple times after having read parts of the data.I plan on adding a test before committing.