SOLR-13681: make Lucene's index sorting directly configurable in Solr #313
Conversation
Resolved Conflicts: solr/solr-ref-guide/src/indexconfig-in-solrconfig.adoc
| @@ -146,6 +146,7 @@ public void testSortingMPSolrIndexConfigCreation() throws Exception { | |||
| final Sort expected = new Sort(new SortField(expectedFieldName, expectedFieldType, expectedFieldSortDescending)); | |||
| final Sort actual = sortingMergePolicy.getSort(); | |||
| assertEquals("SortingMergePolicy.getSort", expected, actual); | |||
| assertEquals("indexSort", expected, iwc.getIndexSort()); | |||
There was a problem hiding this comment.
Let's create a new test method for the new config option, which will survive removal of SMP. Instead of creating yet another solrconfig-xyz.xml I think it should be possible to let the test invoke config-api to set the new setting.
There was a problem hiding this comment.
Yes, I would also favour not creating yet another solrconfig-xyz.xml file. Have used the config-api in tests before but from my research done so far it seems indexConfig is not yet supported by it, or rather 'get' works but 'set' does not?
There was a problem hiding this comment.
Also interestingly V2 'get' works but V1 does not, for indexConfig but not for (say) requestHandler
- both work
curl "http://localhost:8983/solr/gettingstarted/config/requestHandler"
curl "http://localhost:8983/api/collections/gettingstarted/config/requestHandler"
- latter works, former does not
curl "http://localhost:8983/solr/gettingstarted/config/indexConfig"
curl "http://localhost:8983/api/collections/gettingstarted/config/indexConfig"
https://solr.apache.org/guide/8_10/config-api.html#retrieving-the-config lists indexConfig as available top-level section.
$ curl "http://localhost:8983/solr/gettingstarted/config/indexConfig"
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 404 Not Found</title>
</head>
<body><h2>HTTP ERROR 404 Not Found</h2>
<table>
<tr><th>URI:</th><td>/solr/gettingstarted/config/indexConfig</td></tr>
<tr><th>STATUS:</th><td>404</td></tr>
<tr><th>MESSAGE:</th><td>Not Found</td></tr>
<tr><th>SERVLET:</th><td>default</td></tr>
</table>
</body>
</html>
There was a problem hiding this comment.
Ok, perhaps they are R/O because it is not supported to change these after collection creation?
In that case, a new xml file is probably better anyway.
Are you planning to validate that index sorting is working in the test, or simply that the config is set? I think perhaps a new method in the existing IndexConfig test would be enough?
There was a problem hiding this comment.
Yes, and perhaps changing some indexConfig parameters after collection creation would be fine but not so for others. Also the merge policy (factory) configuration is nested, not sure if config-api would easily support that.
Added a new method, modelled on the existing sorting-merge-policy one that will go away with sorting merge policy. There is existing TestSegmentSorting coverage w.r.t. index sorting working in a test, so it might make sense to tap into that somehow?
| if (cmd.getSegmentTerminateEarly()) { | ||
| final Sort cmdSort = cmd.getSort(); | ||
| final int cmdLen = cmd.getLen(); | ||
| final Sort mergeSort = core.getSolrCoreState().getMergePolicySort(); | ||
| final Sort mergeSort = core.getSolrCoreState().getMergePolicySort(); // TODO: need this account for indexSort also? |
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/SOLR-15390 is about deprecating the segmentTerminateEarly flag.
solr/core/src/test/org/apache/solr/cloud/TestSegmentSorting.java
Outdated
Show resolved
Hide resolved
Thanks for attaching SOLR-13681-refguide-skel.patch to the JIRA ticket! If you wish, |
|
Sorry for going silent on this, I'll put it on my radar for next week. |
Resolved Conflicts: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
…er origin/main merge
Resolved Conflicts: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java solr/core/src/test/org/apache/solr/cloud/TestSegmentSorting.java solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
https://issues.apache.org/jira/browse/SOLR-13681