SOLR-15561: Write escaped strings in JsonTextWriter to a StringBuilder before the writer.

[markrmiller]

https://issues.apache.org/jira/browse/SOLR-15561

[risdenk]

This seems like a reasonable change. I merged main to this branch and PR is ready to review.

[dsmiley]

I dunno... if a benchmark shows its faster then cool but I think it's dubious -- probably a needless level of buffering on something that likely already has a buffer.

[epugh]

This does feel like an example where some benchmarks would be nice... As @dsmiley suggested, maybe good, maybe not....

[markrmiller]

One of the very few performance performance improvements I could find in Yonik's code. Of course he had already left a comment about the possibility, which I didn't notice until after working through it.

[HoustonPutman]

@markrmiller did you find this when profiling something?

[markrmiller]

Yeah, Yonik has some really heavy json faceting tests that are easy to look at. Some rare honest tests - far from quick, doing a lot of legitimate work, not bogarting the hardware. One of a small set of tests that really demand a useable @nightly test run. No fat, thorough and comprehensive. An example of tests that should legitimately kick off work to sensible @nightly vs the ones that do so as a workaround.

[github-actions]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!