SOLR-15590 - Context Listener to start CoreContainer #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to CoreContainer)
…a ServletContextListener
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
Show resolved
Hide resolved
dsmiley
reviewed
Nov 8, 2021
| import java.util.ArrayList; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public interface PathExcluder { |
There was a problem hiding this comment.
Do we really need this? And I wonder if "excludePatterns" is a feature that like one person/company uses.
There was a problem hiding this comment.
That's a valid question, but probably deserves it's own issue/discussion.
There was a problem hiding this comment.
I did notice this: which seems to say that this is relied upon by the admin UI. https://issues.apache.org/jira/browse/SOLR-11228
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java
Outdated
Show resolved
Hide resolved
|
meh did that wrong. easier just to remake this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265 updated to latest main with refinements for second review