SOLR-14595: Consistent JSON Facet field overrequest across different facet methods #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…facet methods Extends overrequest capability to `FacetFieldProcessorByEnumTermsStream` for the case where it makes a direct difference: `resort`; and a complementary optimization to avoid `overrequest` for "index" sort on the base `FacetFieldProcessor` class.
…Equiv` Despite beasting heavily, I was not able to find a pre-patch failing seed to sanity-check/confirm that this removal is safe; but relying on `TestJsonFacetRefinement.testIndexAscRefineConsistency()` (which _does_ confirm) should be sufficient.
…facet-indexsort-overrequest
…quest This support maintains backward compatibility with the existing implementation.
…b overrequest" This reverts commit f662e83.
…xplicitly enumerate
…facet-indexsort-overrequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: SOLR-14595
Extends overrequest capability to
FacetFieldProcessorByEnumTermsStreamfor the case where it makes a direct difference:resort; and a complementary optimization to avoidoverrequestfor "index" sort on the baseFacetFieldProcessorclass.