SOLR-15745: Convert create-core v2 API to annotations #450
Conversation
| /** | ||
| * Unit tests for the /cores APIs. | ||
| * | ||
| * Note that the V2 requests made by these tests are not necessarily semantically valid. They shouldn't be taken as |
There was a problem hiding this comment.
Thanks for providing this detail! I tend to look at unit tests as "living documentation" so this is good!
| "'async': 'requestTrackingId' " + | ||
| "}}"); | ||
|
|
||
| // TODO Delete apispec file |
There was a problem hiding this comment.
I'm sure you haven't forgotton about this.
There was a problem hiding this comment.
;-). You did complete these two TODO's
There was a problem hiding this comment.
Haha, yeah, these are remnants from a TODO list I wrote myself at some point. Will remove.
| @JsonProperty | ||
| public Boolean loadOnStartup; | ||
|
|
||
| // If our JsonProperty clone was more feature-rich here we could specify the property be called 'transient', but |
There was a problem hiding this comment.
should we just pick a different parameter name and not use the word transient? I.e, should we go solve this by changing somethign elsewhere so this doesnt' have this issue?
There was a problem hiding this comment.
Well that's what I am doing here for the v2 API. The property name in v2 is "isTransient".
The v1 query parameter is still named "transient". And we could change that, but it'd run afoul of backwards compatibility concerns. I'd need an 8.x release to sneak a deprecation into, which doesn't seem super likely at this point.
Description
Solr currently supports two ways of implementing v2 APIs: an older JSON file ('apispec') based approach, and a new framework that relies on annotations. The code base is a slow transition towards the annotation-based approach, but many APIs remain using the 'apispec' model.
Solution
This PR switches a single API, the "create core" API, over to the new annotation-based framework.
Tests
See V2CoresAPIMappingTest.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.