SOLR-15745: Convert corestatus APIs to annotations #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solr has historically supported two frameworks for definings its v2 APIs: a JSON-based 'apispec' framework, and a more modern replacement that relies on JAX-RS-like annotations to specify endpoints and parameters. The community is in the process of migrating to the annotation based approach, but many apispec APIs remain. This commit converts GET /v2/cores and GET /v2/cores/coreName over to the annotation framework.
epugh
approved these changes
Dec 13, 2021
| @@ -411,6 +413,8 @@ void call() throws Exception { | |||
| public Collection<Api> getApis() { | |||
| final List<Api> apis = Lists.newArrayList(coreAdminHandlerApi.getApis()); | |||
| // Only some core-admin APIs use the v2 AnnotatedApi framework | |||
There was a problem hiding this comment.
is the above comment still true.
There was a problem hiding this comment.
Yep, even after this PR there are the cores.core.Commands and the cores.core.Commands.split` apispec files.
gerlowskija
deleted the
SOLR-15745-core-status-apis-annotation-conversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solr has historically supported two frameworks for definings its v2
APIs: a JSON-based 'apispec' framework, and a more modern replacement
that relies on JAX-RS-like annotations to specify endpoints and
parameters.
The community is in the process of migrating to the annotation based
approach, but many apispec APIs remain.
Solution
This commit converts GET /v2/cores and GET /v2/cores/coreName over to
the annotation framework.
Tests
See V2CoresAPIMappingTest
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.