SOLR-15845 SolrVersion class only recording current version, and based on SemVer

[janhoy]

https://issues.apache.org/jira/browse/SOLR-15845

This is the same patch as #469 except instead of the Lucene-style Version class which keeps a record of all previous verions (which it needs for index-file and analysis compatibility checks), this variant just keeps the current Solr version, and has functionality to enforce SemVer versioning and version comparison, based on SemVer dependency.

[janhoy]

I updated addVersion.py so it works as expected.
Also, instead of updating <luceneMatchVersion> in solrconfig with the new Solr version, it is now updated with the lucene version found in versions.props, alternatively a lucene-version passed as addVersion.py -l <lucene_ver> <solr_ver>.

[thelabdude]

@janhoy ... I think the semver code com.github.zafarkhaja.semver is not Locale aware:

org.apache.solr.util.TestSolrVersion > testVersionComponents FAILED
    org.junit.ComparisonFailure: expected:<[9.0.1]-rc1> but was:<[৯.০.১]-rc1>
        at __randomizedtesting.SeedInfo.seed([EBA979F6BCADAB5F:593FBB0BE14D10A9]:0)
        at org.junit.Assert.assertEquals(Assert.java:117)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at org.apache.solr.util.TestSolrVersion.testVersionComponents(TestSolrVersion.java:31)

Specifically, NormalVersion needs to use a Locale here:

    public String toString() {
        return String.format("%d.%d.%d", major, minor, patch);
    }

[janhoy]

I think the semver code com.github.zafarkhaja.semver is not Locale aware

How do you reproduce this? I see that the semver lib is getting old and there are other alternatives out there. Or we could file a bug there?

[janhoy]

See https://issues.apache.org/jira/browse/SOLR-15896