SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI most of the PR was done quite a while ago in the lucene-solr repo where there are still some comments I left on some of the changes: apache/lucene-solr#1703 |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java
Outdated
Show resolved
Hide resolved
dsmiley
added a commit
that referenced
this pull request
Jan 25, 2022
…ant with MDC (#517) Also, ensured any problems in SolrCore.close has MDC info in logs.
dsmiley
added a commit
that referenced
this pull request
Jan 25, 2022
…ant with MDC (#517) Also, ensured any problems in SolrCore.close has MDC info in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14686
Tests pass.
@joel-bernstein I'm hoping you could take a look here as you've worked on the SolrLogPostTool. I noticed the test expects a newSearcher to not have MDC but I suspect that's not the case these days?