SOLR-15283 GlobalTracer overhaul #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Solr's GlobalTracer is gone. Use OpenTracing's GlobalTracer, or even better: getters on CoreContainer, SolrQueryRequest, etc. * No more "samplingThreshold" cluster property. Instead, configure sampling specific to the plugin. * Ensure the active span is visible from all threads by using ExecutorUtil
|
I think this is ready; I'll merge it Friday. |
# Conflicts: # solr/core/src/java/org/apache/solr/core/CoreContainer.java
…OLR-15238-GlobalTracer
|
The ticket number in CHANGES.txt is SOLR-15238, not SOLR-15283. |
|
Thanks @ryo0301 ; I pushed a fix. |
epugh
pushed a commit
to epugh/solr
that referenced
this pull request
Oct 22, 2021
* Solr's GlobalTracer is gone. Use OpenTracing's GlobalTracer, or even better: getters on CoreContainer, SolrQueryRequest, etc. * No more "samplingThreshold" cluster property. Instead, configure sampling specific to the plugin. * Ensure the active span is visible from all threads by using ExecutorUtil * JaegerTracerConfigurator is now configured via sys props / env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15283
(for overall concerns, discuss in JIRA)
TODO: