Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic #562

Merged
merged 3 commits into from Jan 25, 2022
Merged

SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic #562

merged 3 commits into from Jan 25, 2022

Conversation

cpoerschke
Copy link
Contributor

@cpoerschke
Copy link
Contributor Author 

- public final class LTRThreadModule implements CloseHook, NamedListInitializedPlugin 
+ public final class LTRThreadModule implements NamedListInitializedPlugin

is technically an signature change and so it would be nice to include this in 9.0 if not too late? Then again, LTRThreadModule is sort of internal implementation detail and a 9.0-to-9.1 signature change for it wouldn't be too bad either.

solr/CHANGES.txt entry yet to be added once it's clear which section.

janhoy
janhoy approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1 for 9.0, looks safe

alessandrobenedetti
alessandrobenedetti approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@alessandrobenedetti alessandrobenedetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a reasonable change!
+1

@cpoerschke cpoerschke merged commit 957c57d into apache:main Jan 25, 2022
@cpoerschke cpoerschke deleted the SOLR-15953 branch January 25, 2022 17:26
asfgit pushed a commit that referenced this pull request Jan 25, 2022
@cpoerschke
SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic (#562
6579584 
)

(cherry picked from commit 957c57d)
asfgit pushed a commit that referenced this pull request Jan 25, 2022
@cpoerschke
SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic (#562
6e07350 
)

(cherry picked from commit 957c57d)
(cherry picked from commit 6579584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhoy janhoy janhoy approved these changes

@alessandrobenedetti alessandrobenedetti alessandrobenedetti approved these changes

@madrob madrob madrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cpoerschke @janhoy @alessandrobenedetti @madrob