SOLR-15853 Solr paramset impl #594
Conversation
|
You can also check this newly added feature from the screenshots I have added.
|
| @@ -209,7 +247,7 @@ solrAdminApp.controller('QueryController', | |||
| $location.search(key, adminParams[key]); | |||
| } | |||
| var currentUrl = $location.$$url; | |||
| if (previousUrl === currentUrl) { //if the query send with same parameters the query should be executed | |||
| if (previousUrl === currentUrl) { //if the query send with same parameters | |||
There was a problem hiding this comment.
old comment looks better than new one. please return back to old
There was a problem hiding this comment.
@betulince I don't think this comment was addressed.
solr/webapp/web/partials/query.html
Outdated
| @@ -23,6 +23,18 @@ | |||
| </label> | |||
| <input type="text" ng-model="qt" id="qt" placeholder="/select" value="/select" title="Request handler in solrconfig.xml."> | |||
|
|
|||
| <div> | |||
There was a problem hiding this comment.
I would recommend that field should be optional. If the core has paramsets then it should be shown. otherwise it should not be shown..
But it's up to you
|
This is Super Exciting! I am going to go through and test this, but probably not till Monday. One thing is, I wonder, now that we are exposing this in the UI, I wonder if the best name is ParamSets? I am going to start a thread on the Dev list about the name of this feature. It may amount to some bikeshedding, or now may be the time to come up with a better name to describe configuring a Solr end point. If you are not on the dev list, you might want to join @betulince |
|
Of course, I think it would be useful to ask on the dev list and get
everyone's opinion to find the most suitable name.
Also, we can change the icon too :-)
Eric Pugh ***@***.***>, 4 Şub 2022 Cum, 17:34 tarihinde şunu
yazdı:
… This is Super Exciting! I am going to go through and test this, but
probably not till Monday.
One thing is, I wonder, now that we are exposing this in the UI, I wonder
if the best name is ParamSets? I am going to start a thread on the Dev list
about the name of this feature. It may amount to some bikeshedding, or now
may be the time to come up with a better name to describe configuring a
Solr end point.
—
Reply to this email directly, view it on GitHub
<#594 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKSKE2HL4EK7RHB6ZCRQSCDUZPPWHANCNFSM5NRXL3UQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Can't wait to see what you added... FYI, over the weekend I needed a better "multiselect", and someone had recommended selectize.js, so I rolled that in as part of this #745 It supposedly has drag and drop ordering, though I haven't figured that out! |
|
looks like |
|
is package.json actually integrated into the build? I think we've never had one before... |
# Conflicts: # solr/webapp/web/css/angular/query.css
|
hey! I deleted package.json and package-lock.json. They are not related with the improvement, I just added while I was trying some things :) And I didn't send the improvement on paramset screen yet. I'll send it in some hours, I am just checking and doing final touches. Sorry for late reply it's just 3 am in the morning in turkey :) I am excited for the results!! |
|
Improvement done. It works correctly according to my tests. Instead of copying the placeholder, it made more sense to show a sample json and have it copied... |
There was a problem hiding this comment.
I don't have comments on the functionality of this. I think there is one existing review comment not addressed.
#745 and this PR both try to pull in a UI framework for selection. @epugh did you get to see which one is better to go with?
I also saw @epugh left a video comment in https://issues.apache.org/jira/browse/SOLR-15853?focusedCommentId=17491578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17491578 - I didn't watch it but it seems like @epugh would be a good one to take another look.
| @@ -209,7 +247,7 @@ solrAdminApp.controller('QueryController', | |||
| $location.search(key, adminParams[key]); | |||
| } | |||
| var currentUrl = $location.$$url; | |||
| if (previousUrl === currentUrl) { //if the query send with same parameters the query should be executed | |||
| if (previousUrl === currentUrl) { //if the query send with same parameters | |||
There was a problem hiding this comment.
@betulince I don't think this comment was addressed.
I just deleted the comment. @epugh maybe you can give another look at the code! |
|
Finally getting back to this (I am on day 2 of a three day drive across america! ;-) ).... I don't know WHY I thought |
|
I did a bunch of work, but for some reason couldn't push to the existing branch, so I had to create a new pull request at #923, so closing this one in favour of the new one! |
https://issues.apache.org/jira/browse/SOLR-15853
Description
A screen where paramset can be created has been added to the admin tool. You can set a new paramset on this screen and bring this paramset. When the get paramset button is pressed, you can see all the paramsets that this collection has. You can only display it by typing a paramset whose name you know in the input field.
In addition, a new section has been added to the query screen, enabling the use of the paramset desired to be used in this field. Multiple selection is also possible here. If you select the paramsets you want to use and say execute query, you will see that this paramset is added to the url as useParam=paramset_name and returns the correct results.
I applied the films example in this link to test it, it gave the expected results.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.