SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only supports push-down for LogicalAggregate #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelabdude
added a commit
to thelabdude/solr
that referenced
this pull request
Feb 12, 2022
…upports push-down for LogicalAggregate (apache#626)
thelabdude
added a commit
to thelabdude/solr
that referenced
this pull request
Feb 12, 2022
…upports push-down for LogicalAggregate (apache#626) (apache#627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15974
Disable the
EnumerableRules.ENUMERABLE_AGGREGATE_RULEoptimization so that Solr only deals with LogicalAggregate. I looked into adding another rule for EnumerableAggregate but it seemed like we don't need this optimization from Calcite since we're pushing down into Solr's agg engine anyway, we don't need a bunch of optimizations in the Calcite layer.