New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-15972 Add wrapper jar and export-ignore attr #634
Conversation
Tested via: git archive --format tgz HEAD | tar -zt | grep wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the no-binary requirement is for releases only, I guess this solution is acceptable.
I'm not sure why you want to have the wrapper versioned - for me it's one way or the other. Since you can't publish it in source releases and the infrastructure to automatically download it is in place - why add things to make it more complicated? |
I'm just trying to make my internal, non internet accessible CI work. Like I said on the Jira, I have a maven mirror but not a GitHub mirror. I suppose the other option is that I install gradle from somewhere and use that instead of the wrapper? |
bq. I'm just trying to make my internal, non internet accessible CI work Fair enough. The only thing that comes to my mind is to download the wrapper manually and place it where it should be placed then. Another alternative for isolated networks would be a git mirror with that wrapper checked in on a downstream branch. bq. I suppose the other option is that I install gradle from somewhere and use that instead of the wrapper? Yes, if it's the same version, it'll work just fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. If we have to remove it in the future, so be it, but this does solve the original reason it was taken away.
It's not a huge file (not nearly the biggest in our repo), and checking it in is recommended by Gradle.
I'm +0. My view is very polarized - either remove the gradle wrapper download infrastructure or use it for what it was added. Occam's razor. |
I ended up being able to install the full gradle version and use that for CI instead of trying to hack around the wrapper being missing. |
Tested via:
git archive --format tgz HEAD | tar -zt | grep wrapper
https://issues.apache.org/jira/browse/SOLR-15972