SOLR-14920: Format code automatically and enforce it in Solr solrj/st… #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErickErickson
requested review from
risdenk,
madrob,
dsmiley and
gerlowskija
dsmiley
requested changes
Feb 26, 2022
| @@ -0,0 +1,3 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
Let's not add such in a PR about indentation
| @@ -0,0 +1,18 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
Thanks @ErickErickson! I can pull these specific changes into #706 to have it all in one commit at the end. I'll cherry pick these changes over. |
|
Pulled the relevant changes into PR #706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ream/io
https://issues.apache.org/jira/browse/SOLR-14920 for solrj/stream/io
I went over all the changes and fixed up what looked odd. All tests pass. I'll leave it to others to merge when the time is right.
NOTE: spotless.gradle will need to be resolved since I listed everything in solrj except stream/io in the targetExclude list. That should just be deleting the entire case though once all the other solrj code is checked in...