SOLR-14401: Add back in missing metric and fix graphana dashboard #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhoy
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Race condition with #771, and now I understand why I could not find an equivalent metric for the test in my other commit - it was missing :) I missed this PR earlier today so went ahead with my own fix. Should have waited for your review on that PR. While it won't matter much which of the two we use for the test, feel free to use your "new" one.
Not tested the Grafana change but looks right.
HoustonPutman
added a commit
that referenced
this pull request
Mar 28, 2022
(cherry picked from commit 96650fb)
HoustonPutman
added a commit
that referenced
this pull request
Mar 28, 2022
(cherry picked from commit 96650fb)
|
No worries, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14401
This adds back a metric that was removed in the previous PR (
solr_metrics_core_query_local_count) but renames it to follow the common pattern used elsewhere (solr_metrics_core_query_requests_total).I have also fixed the three uses of
_localthat persisted in the graphana dashboard.This fixes the broken prometheus-exporter docker tests.